sandros/laps
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 22 Activity

Fixed type crash when URL passed to network request filters is invalid.

Browse Source 
Fixes #42
This commit is contained in:
Andrey Savchenko committed 2020-03-11 12:58:12 +02:00
1 parent dc88dcce1e
commit b0584dea0a
2 files changed
+16 -5
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Record/Collector/Http_Collector.php
+15 -5
View File
@@ -43,11 +43,16 @@ class Http_Collector extends Stopwatch_Collector {
* @param string $url The request URL.
*
* @return false|array|\WP_Error
*
* @psalm-suppress RedundantConditionGivenDocblockType
* @noinspection PhpUnusedParameterInspection
*/
public function pre_http_request( $false, array $args, string $url ) {
public function pre_http_request( $false, $args, $url ) {
$this->start( $url, 'http' );
$this->callers[ $url ] = wp_debug_backtrace_summary( __CLASS__, 5 );
if ( $url && is_string( $url ) ) {
$this->start( $url, 'http' );
$this->callers[ $url ] = wp_debug_backtrace_summary( __CLASS__, 5 );
}
return $false;
}
@@ -62,10 +67,15 @@ class Http_Collector extends Stopwatch_Collector {
* @param string $url The request URL.
*
* @return array|\WP_Error
*
* @psalm-suppress RedundantConditionGivenDocblockType
* @noinspection PhpUnusedParameterInspection
*/
public function http_api_debug( $response, string $type, $class, array $args, string $url ) {
public function http_api_debug( $response, $type, $class, $args, $url ) {
$this->stop( $url );
if ( $url && is_string( $url ) ) {
$this->stop( $url );
}
return $response;
}